[RESOLVED NOT A BUG] [41.53] Zombie attacks create holes twice

[PseudonymousEd]

EDIT: Sorry, I missed the ! in front of bl.  This is not a bug.  My mistake.

 

I don't know if this is intentional, but it *feels* like it shouldn't be.

 

Before the zombie attack roll to hit, there is a line of code (BodyDamage):

 

bl = this.getParentChar().addHoleFromZombieAttacks(BloodBodyPartType.FromIndex(n3));

 

And once it is determined to be a hit (for scratches, lacerations, and bites), after you know the attack got through the protection, the hole is created again:

 

 

                if (!bl) {
                    this.getParentChar().addHole(BloodBodyPartType.FromIndex(n3));
                }

 

The reason this seems repetitive is because inside of addHoleFromZombieAttacks (IsoGameCharacter) it already creates a hole if it has been determined there should be a hole:

 

        if (n != 0) {
            this.addHole(bloodBodyPartType);
        }
        return n != 0;

 

This also means that a body part's clothes can get a hole, then get hit (because of the reduced protection from the hole), then get another hole in another piece of clothing.  I'm not sure if that is intended or not.

 

I have a pastebin of the section of BodyDamage I am talking about (only the part where scratches are resolved, but it also applies to the laceration and bite sections).

https://pastebin.com/sQCjfMKW

Edited August 22, 2021 by PseudonymousEd
Realized I was wrong. This is not a bug.