performance issues?

[ProjectSky]

If the player has too many items in the inventory(i have 2000+ nails) game will freeze every time they right-click, this a known performance issue?

[EnigmaGrey]

Any chance you're using a mod? It's most likely that it's using an older version of the inventory pane.

Tested here with 10k nails without issue on a vanilla game. 

[ProjectSky]

version 41.66 no mod

i mean right click on the world tile, not right click in player inventory

update: 41.65 is the same

[ProjectSky]

i have 49k+ nails in inventory, right click game freezes 5+ sec

this is a extreme test, but developers need to be notice this issues

[EnigmaGrey]

56 minutes ago, ProjectSky said:

i have 49k+ nails in inventory, right click game freezes 5+ sec

this is a extreme test, but developers need to be notice this issues

At that point the game is going to crash if you even interact with them.

Though I agree it's a bug, I don't think it makes much sense to try and program out of states that should never be reached in the normal play of the game. I mean the only defense against this would likely be putting a hard cap on the number of items in the inventory, for example. It's just an entirely unreasonable amount of items to expect the game to interact with well.

[ProjectSky]

44 minutes ago, EnigmaGrey said:

At that point the game is going to crash if you even interact with them.

Though I agree it's a bug, I don't think it makes much sense to try and program out of states that should never be reached in the normal play of the game. I mean the only defense against this would likely be putting a hard cap on the number of items in the inventory, for example. It's just an entirely unreasonable amount of items to expect the game to interact with well.

i don't think set a limit is good thing, dev should try optimize it if possible

[EnigmaGrey]

7 hours ago, ProjectSky said:

i don't think set a limit is good thing, dev should try optimize it if possible

Eh. People are going to have to exercise some common sense, I think. (Just because you can, doesn’t mean you should.)

 

 You can’t spawn 10k zombies and expect the game to handle it. Same thing for 50k items.

 

Neither never happen during normal play.

[ProjectSky]

11 hours ago, EnigmaGrey said:

Eh. People are going to have to exercise some common sense, I think. (Just because you can, doesn’t mean you should.)

 

 You can’t spawn 10k zombies and expect the game to handle it. Same thing for 50k items.

 

Neither never happen during normal play.

you are right, this test is too extreme

i hope pz can standard base things of the engine, hope it can become better